Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python to 3.8 on Windows #677

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Bump Python to 3.8 on Windows #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7467,7 +7467,8 @@ const pip3Packages = ["lxml", "netifaces"];
*/
function prepareRos2BuildEnvironment() {
return __awaiter(this, void 0, void 0, function* () {
const python_dir = tc.find("Python", "3.7");
// Currently targeted Python version for Windows according to REP 2000
const python_dir = tc.find("Python", "3.8");
yield utils.exec(path.join(python_dir, "python"), [
"-c",
"import sysconfig; print(sysconfig.get_config_var('BINDIR')); print(sysconfig.get_path('scripts'))",
Expand Down
3 changes: 2 additions & 1 deletion src/setup-ros-windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ const pip3Packages: string[] = ["lxml", "netifaces"];
* Install ROS 2 build tools.
*/
async function prepareRos2BuildEnvironment() {
const python_dir = tc.find("Python", "3.7");
// Currently targeted Python version for Windows according to REP 2000
const python_dir = tc.find("Python", "3.8");

await utils.exec(
path.join(python_dir, "python"),
Expand Down
Loading