Support bounded and unbounded arrays with rqt_plot (This should NOT be merged to crystal) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2020 21:21
|
@brawner and @dirk-thomas please review |
brawner
reviewed
Apr 7, 2020
| if array_idx < 0: | ||
| return slot_type, False, None | ||
| topic_type_info = message_field_type_helpers.MessageFieldTypeInfo(topic_type_str) | ||
| slot_type = topic_type_info.base_type_str |
There was a problem hiding this comment.
These two variables are not used except as a return, you might as well just put them in the return directly.
| if end_array_idx < 0: | ||
| return None, False, None | ||
| if topic_type_info.is_static_array: | ||
| array_size = topic_type_info.static_array_size |
There was a problem hiding this comment.
I think it makes sense to create a helper function (in message_helpers.py?) that calculates array size with this information.
src/rqt_plot/plot_widget.py
Outdated
|
|
||
| # TODO: add bytes to this as you could treat bytes as an array of uint |
There was a problem hiding this comment.
Byte array is standard type, so I think this should be included and nix the TODO
There was a problem hiding this comment.
On further consideration, I don't think we should do this. It would be like plotting the first character of a string. Not that useful imho
mlautman
changed the title
|
Closing in favor of #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on As it depends on ros-visualization/rqt#224
By taking advantage of bounded and unbounded array support in rqt_py_common field parsing, we are able to once again plot values out of variable size arrays with rqt_plot
This change involved more or less reverting rosplot.py, and plot_widget.py to their ros1 equivalents and then using the new RQT_py_common support for dealing with bounded and unbounded arrays.