-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaned package qt_gui_icons -> tango_icons_vendor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Closed
dirk-thomas
reviewed
Jun 4, 2020
Signed-off-by: ahcorde <[email protected]>
brawner
reviewed
Jun 4, 2020
dirk-thomas
reviewed
Jun 4, 2020
dirk-thomas
reviewed
Jun 4, 2020
dirk-thomas
reviewed
Jun 5, 2020
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
dirk-thomas
reviewed
Jun 18, 2020
CMakeLists.txt
Outdated
endif() | ||
option(INSTALL_TANGO_ICONS "Install Tango icons" ${INSTALL_TANGO_ICONS_DEFAULT_VALUE}) | ||
|
||
if (INSTALL_TANGO_ICONS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the linters which will flag this line.
Signed-off-by: ahcorde <[email protected]>
dirk-thomas
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linters can be added in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaned package qt_gui_icons -> tango_icons_vendor
Signed-off-by: ahcorde [email protected]