Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaned package qt_gui_icons -> tango_icons_vendor #4

Merged
merged 8 commits into from
Jun 19, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 4, 2020

Remaned package qt_gui_icons -> tango_icons_vendor

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the enhancement New feature or request label Jun 4, 2020
@ahcorde ahcorde requested review from brawner and dirk-thomas June 4, 2020 08:21
@ahcorde ahcorde self-assigned this Jun 4, 2020
@ahcorde ahcorde mentioned this pull request Jun 4, 2020
package.xml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
package.xml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated
endif()
option(INSTALL_TANGO_ICONS "Install Tango icons" ${INSTALL_TANGO_ICONS_DEFAULT_VALUE})

if (INSTALL_TANGO_ICONS)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the linters which will flag this line.

Signed-off-by: ahcorde <[email protected]>
Copy link

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters can be added in a separate PR.

@ahcorde ahcorde merged commit b53ca96 into master Jun 19, 2020
@ahcorde ahcorde deleted the ahcorde/package_name branch August 19, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants