making rostest optional in most packages

[bulwahn]

These commits replaces local patches by the patches provided upstream and removes the package dependencies on rostest.

In fact, all packages in meta-ros are configured, compiled and installed without any tests. Nevertheless, the packages still required the dependency on rostest, as it was requested by the CMakeLists.txt in its find_package (catkin REQUIRED ...) call. By the provided patches, the CMakeLists.txt now does not request the rostest package, when configured without tests.

As a final result, the images built with meta-ros now do not include the rostest library anymore, which was a dead binary on the image before anyway.

[herbrechtsmeier]

👍

[KristofRobot]

@bulwahn

Could you elaborate on the rationale to make rostest optional? I dont think this is for build/run reasons, as I believe these packages built and ran fine before this patch (i.e. with rostest).

Thanks!

[bulwahn]

@KristofRobot:
In fact, all packages in meta-ros are configured, compiled and installed without any tests. Nevertheless, the packages still required the dependency on rostest, as it was requested by the CMakeLists.txt in its find_package (catkin REQUIRED ...) call. By the provided patches, the CMakeLists.txt now does not request the rostest package, when configured without tests.

As a final result, the images built with meta-ros now do not include the rostest library anymore, which was a dead binary on the image before anyway.

(I added this explanation to the commit message of this pull request as well.)

[KristofRobot]

@bulwahn - thanks for the explanation - merged.