Move queue operations to after debug message so that tenses of message match reality. #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e match reality. Before this change a queue with a limit of 1 element would report the following debug message: Incoming queue full for topic "baz". Discarding oldest message (current queue size [0]) which implies that the queue is full when it holds 0 elements.
|
I am not sure if changing the order makes the message much clearer. I would read it as events in temporal order and with that the current number makes sense:
|
|
If you are happy with the existing message then I'm OK with that. I found it difficult to interpret without looking at the code. I'm OK with this PR getting declined. |
|
Maybe the message can be improved to make it clear to everyone what it means. Can you suggest a rephrased message which is clear to you? |
|
The following message could be used in place of moving the queue logic around. Incoming queue was full for topic "baz". Discarded oldest message (current queue size [0]) |
dirk-thomas
added a commit
that referenced
this pull request
Jun 27, 2016
|
Thanks. I have updated the message with your suggestions: c710fbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change a queue with a limit of 1 element would report the following debug message:
Incoming queue full for topic "baz". Discarding oldest message (current queue size [0])
which implies that the queue is full when it holds 0 elements and that it will discard a message even without elements.
After this change you'll get the message:
Incoming queue full for topic "baz". Discarding oldest message (current queue size [1])
(low-pri PR, quality of life only)
@dirk-thomas