Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gennodejs: 1.0.1-0 in 'kinetic/distribution.yaml' [bloom] #11319

Merged
merged 3 commits into from
Apr 27, 2016
Merged

gennodejs: 1.0.1-0 in 'kinetic/distribution.yaml' [bloom] #11319

merged 3 commits into from
Apr 27, 2016

Conversation

IanTheEngineer
Copy link
Contributor

Increasing version of package(s) in repository gennodejs to 1.0.1-0:

gennodejs

* Package name-switch from genjs to gennodejs based on feedback
* When deserializing, creates an instance of the message
  rather than using json.
* Update genjs for install
  -No longer includes hardcoded paths in generated message files
  -Actually install stuff
* Contributors: Chris Smith, Ian McMahon, chris-smith

@IanTheEngineer
Copy link
Contributor Author

IanTheEngineer commented Apr 27, 2016

Should I add an additional commit here to remove genjs?

@dirk-thomas
Copy link
Member

You can either add it to this PR or create a separate one.

@IanTheEngineer
Copy link
Contributor Author

Alrighty, I'll have that up in this one momentarily.

@IanTheEngineer
Copy link
Contributor Author

This is the package rename from genjs --> gennodejs. Could you please clean out the debs and docs for genjs. Thanks!

@dirk-thomas
Copy link
Member

Please also add doc and source entries.

@dirk-thomas
Copy link
Member

Please also take the time to create a package page in the wiki for it (http://wiki.ros.org/gennodejs). The package header will then be populated by the doc job.

@dirk-thomas
Copy link
Member

@tfoote Can you please remove all old artifacts of genjs (doc, source and binary packages).

@IanTheEngineer
Copy link
Contributor Author

Thanks for the pointers, Dirk. I created the package template wiki page and added the source and doc info for rosdistro.

@dirk-thomas dirk-thomas merged commit a8261e9 into ros:master Apr 27, 2016
@IanTheEngineer IanTheEngineer deleted the bloom-gennodejs-0 branch February 23, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants