Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument for target framework in tests #4

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Add argument for target framework in tests #4

merged 2 commits into from
Apr 20, 2023

Conversation

hoffmann-stefan
Copy link
Member

@hoffmann-stefan hoffmann-stefan commented Apr 15, 2023 •
edited
Loading

This allows to pass the TARGET_FRAMEWORK for tests explicitly to add_dotnet_test().

used by ros2-dotnet/ros2_dotnet#98

add_dotnet_test(test_messages
  TARGET_FRAMEWORK "net6"
  SOURCES
  ${CS_SOURCES}
  # ...
)

@hoffmann-stefan hoffmann-stefan marked this pull request as ready for review April 15, 2023 16:11
@hoffmann-stefan hoffmann-stefan changed the title [WIP] Add argument for target framework in tests Add argument for target framework in tests Apr 15, 2023
@hoffmann-stefan hoffmann-stefan mentioned this pull request Apr 15, 2023
Merged
1 task
@hoffmann-stefan
change default test target framework to net6.0
15b00f4 
netcoreapp2.0 is not supported anymore
@hoffmann-stefan hoffmann-stefan merged commit c1f263d into ros2-dotnet:master Apr 20, 2023
@hoffmann-stefan hoffmann-stefan deleted the feature/pass-target-framework-to-tests branch April 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoffmann-stefan