Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workaround as connext declares dep on libdl now #219

Closed
wants to merge 1 commit into from

Conversation

mikaelarguedas
Copy link
Member

connects to ros2/rmw_connext#275

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Dec 11, 2017
@dhood
Copy link
Member

dhood commented Dec 11, 2017

I think this was added specifically for the linktime_composition part of the demo (I imagine otherwise the linker would not bother to link against the various components because they are not coded dependencies in linktime_composition.cpp). I don't think it's related to the connext workaround (which was probably redundant by the time this demo was created)

@mikaelarguedas
Copy link
Member Author

Thanks for the feedback, yeah that was my guess too and wanted to confirm it would fail without it. As usual this is not ready for review until being placed in the review column.

@dhood
Copy link
Member

dhood commented Dec 11, 2017

Personally I appreciate input from others as soon as possible if it looks like I'm going in the wrong direction with something, so I figured I'd point it out even if the PR is labelled as "in progress", didn't mean to step on your toes 😄

@mikaelarguedas
Copy link
Member Author

Yeah I understood your intent that's why I thanked the feedback. I'll make it clearer in the future when I'm confirming the need for extra logic and not expecting reviews on it 😉 .

@mikaelarguedas mikaelarguedas deleted the remove_connext_workaround branch December 11, 2017 18:55
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants