Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle rostest #336

Merged
merged 3 commits into from
May 17, 2019
Merged

Add lifecycle rostest #336

merged 3 commits into from
May 17, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 15, 2019

Connected to ros2/ros_testing#1. This pull request adds a test equivalent to the lifecycle demo to exercise the ros_testing infrastructure.

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 15, 2019
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits.

lifecycle/test/test_lifecycle.py Outdated Show resolved Hide resolved
lifecycle/test/test_lifecycle.py Outdated Show resolved Hide resolved
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic merged commit 0dd9e89 into master May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/add-ros2-testing branch May 17, 2019 04:10
@hidmic hidmic removed the in review Waiting for review (Kanban column) label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants