-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[intra_process_demo] executable name in README.md fix-up #690
Conversation
Signed-off-by: Trushant Adeshara <[email protected]>
@Trushant-Adeshara-UM
i do not see them. probably caching in your local repo? |
@fujitatomoya quick question, it is the executable name that needs to be changed in the README.md. So, I just modified that line in the file and committed. Is there something else which I am missing? |
Signed-off-by: Trushant Adeshara <[email protected]>
@ahcorde i will leave this to you for your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
This is just documentation, merging! |
https://github.com/Mergifyio backport jazzy iron |
✅ Backports have been created
|
Signed-off-by: Trushant Adeshara <[email protected]> (cherry picked from commit 4a18995)
Signed-off-by: Trushant Adeshara <[email protected]> (cherry picked from commit 4a18995)
Signed-off-by: Trushant Adeshara <[email protected]> (cherry picked from commit 4a18995) Co-authored-by: Trushant Adeshara <[email protected]>
Signed-off-by: Trushant Adeshara <[email protected]> (cherry picked from commit 4a18995) Co-authored-by: Trushant Adeshara <[email protected]>
Would like to add that the node name needs to be updated to watermark_node (instead of watermarked_node), Line 75 in the README.md. Node name here.