New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a tf2_bullet::tf2_bullet target #495

Merged

sloretz merged 2 commits into ros2 from tf2_bullet__modern_cmake

Mar 30, 2022

Contributor

sloretz commented Jan 8, 2022 •

edited

Loading

Split from #493

This makes tf2_bullet use more modern CMake. It now exports a tf2_bullet::tf2_bullet target, avoids ament_target_dependencies() (ament/ament_cmake#292), and wraps the use of BULLET_INCLUDE_DIRS and BULLET_LIBRARIES with a tf2_bullet::Bullet target.

Requires ros2/choco-packages#18
Requires ros-infrastructure/ros2-cookbooks#42


          Export a tf2_bullet::tf2_bullet target

8a94e31

Signed-off-by: Shane Loretz <[email protected]>

sloretz self-assigned this

Contributor Author

sloretz commented Jan 8, 2022

CI (build: --packages-above-and-dependencies tf2_bullet test: --packages-above tf2_bullet)

Linux
Linux-aarch64
Windows

sloretz commented

View reviewed changes

tf2_bullet/bullet-extras.cmake Show resolved Hide resolved


          Add in bullet compile definitions

a51cd7f

Signed-off-by: Shane Loretz <[email protected]>

sloretz mentioned this pull request

Bullet from vcpkg and update to 3.17 ros2/choco-packages#18

Merged

Contributor Author

sloretz commented Mar 30, 2022

CI again now that Windows CI should be using the latest bullet version

Linux
Linux-aarch64
Windows

Contributor Author

sloretz commented Mar 30, 2022

Windows CMake warning is also on the nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2256/cmake/new/

so CI LGTM!

gbiggs approved these changes

View reviewed changes

sloretz merged commit ace3644 into ros2

delete-merged-branch bot deleted the tf2_bullet__modern_cmake branch

March 30, 2022 22:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet