Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio errors on Windows #7

Closed
wjwwood opened this issue Aug 31, 2015 · 5 comments
Closed

asyncio errors on Windows #7

wjwwood opened this issue Aug 31, 2015 · 5 comments
Assignees

Comments

@wjwwood
Copy link
Member

wjwwood commented Aug 31, 2015

On my latest Windows job I'm seeing errors like this:

http://ci.ros2.org/job/ros2_batch_ci_windows/299/console

19:09:05 39: ======================================================================
19:09:05 39: ERROR: test_publisher_subscriber_cpp__nested__rmw_connext_dynamic_cpp__rmw_connext_cpp.test_publisher_subscriber
19:09:05 39: ----------------------------------------------------------------------
19:09:05 39: Traceback (most recent call last):
19:09:05 39:   File "C:\tools\python\lib\site-packages\nose\case.py", line 198, in runTest
19:09:05 39:     self.test(*self.arg)
19:09:05 39:   File "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\test_communication\test_publisher_subscriber_cpp__nested__rmw_connext_dynamic_cpp__rmw_connext_cpp.py", line 22, in test_publisher_subscriber
19:09:05 39:     rc = launcher.launch()
19:09:05 39:   File "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\install\Lib\site-packages\launch\launcher.py", line 57, in launch
19:09:05 39:     asyncio.get_event_loop_policy().set_child_watcher(None)
19:09:05 39:   File "C:\tools\python\lib\asyncio\events.py", line 486, in set_child_watcher
19:09:05 39:     raise NotImplementedError
19:09:05 39: nose.proxy.NotImplementedError: 
19:09:05 39: -------------------- >> begin captured stdout << ---------------------

I think it might be related to this change?: 3684223#diff-64876ece93fadad6549af3a8bcb112c7R57

I'm not sure though.

@dirk-thomas dirk-thomas self-assigned this Aug 31, 2015
@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Aug 31, 2015
@dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 31, 2015
@tfoote
Copy link
Contributor

tfoote commented Aug 31, 2015

The ci finished with a lot of test failures. (83)

@dirk-thomas
Copy link
Member

The problem is that the not succeeding tests are already there before: e.g. in http://ci.ros2.org/job/ros2_batch_ci_windows/299/

But since the nosetests are marked as "errors" and not "failures" the Jenkins xUnit plugin (configured for GoogleTests) does not pick them up as failing tests.

Therefore I would propose to merge #8 since it clearly fixes the invocation of a not existing method on Windows. And after that the tests still need to be fixed.

dirk-thomas added a commit that referenced this issue Aug 31, 2015
only unset watcher when not on Windows (fix #7)
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Aug 31, 2015
@dirk-thomas dirk-thomas reopened this Aug 31, 2015
@dirk-thomas
Copy link
Member

Since #8 only fixed the reporting (by not having tests with "errors" but "failures") I will reopen this.

The current state is getting build in: http://ci.ros2.org/job/ros2_batch_ci_windows/309/

@dirk-thomas
Copy link
Member

Closed by #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants