-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asyncio errors on Windows #7
Comments
I started http://ci.ros2.org/job/ros2_batch_ci_windows/301/ with #8. |
The ci finished with a lot of test failures. (83) |
The problem is that the not succeeding tests are already there before: e.g. in http://ci.ros2.org/job/ros2_batch_ci_windows/299/ But since the nosetests are marked as "errors" and not "failures" the Jenkins xUnit plugin (configured for GoogleTests) does not pick them up as failing tests. Therefore I would propose to merge #8 since it clearly fixes the invocation of a not existing method on Windows. And after that the tests still need to be fixed. |
only unset watcher when not on Windows (fix #7)
Since #8 only fixed the reporting (by not having tests with "errors" but "failures") I will reopen this. The current state is getting build in: http://ci.ros2.org/job/ros2_batch_ci_windows/309/ |
Closed by #9. |
On my latest Windows job I'm seeing errors like this:
http://ci.ros2.org/job/ros2_batch_ci_windows/299/console
I think it might be related to this change?: 3684223#diff-64876ece93fadad6549af3a8bcb112c7R57
I'm not sure though.
The text was updated successfully, but these errors were encountered: