Import apex rostest #209

wjwwood · 2019-03-20T18:46:23Z

- Arguments work like regular launch arguments: apex_rostest name_of_test.py arg:=foo - Added a mesasge pump class that will spin some rclpy nodes on a background thread automatically

Add launch arguments to apex_rostest

…h API

- Rename apex_rostest to apex_launchtest - Remove rclpy deps from apex_launchtest - Remove launch_ros deps from apex_launchtest - Move ros and rclpy deps into a new package, apex_launchtest_ros - Add two examples to apex_launchtest that don't require ROS - Update tests that used the ROS nodes previously in apex_rostest to use non ROS processes - Update license from "all rights reserved" to apache

Change apex_rostest to apex_launchtest

- Build and test apex_launchtest only - Build and test everything (apex_launchtest + apex_launchtest_ros) - Coverage report

- Git rid of extra sh -c (left over from a copy/paste) - Build jobs only save 'build' and 'install' artifacts - test_all job saves 'build', 'install', 'log', and globs for .coverage files

Add gitlab ci

- Use symlink-install, otherwise coverage we get through subprocess calls ends up in a different place than coverage we get through calling functions directly from tests

Fix coverage report

More output when node dies

- Gave all of these methods the same signature. They can all take ExecuteProcess actions or strings - New util to handle the lookup of process actions in one place

Have IO and Exit Code asserts use the same lookup

* Initial README.md doc and improved example * Address review comments * Describe assertions * Describe arguments * Address second round of review comments * Update README.md One more round of addressing comments

Test xml output

- Do an isolated build from source to catch issues with missing deps - Add a line (commented) that will fail the build if rclpy is a dep for apex_launchtest - Set up job to run on a schedule (schedule will need to be added to CI) because it's very long

- Remove ros2launch dep from apex_launchtest, which should also remove rclpy dep - Add test for the '--show-args' argument - enable CI check for rclpy dep

Remove rclpy from apex_launch

Fix rclpy dep (again)

- This bug happened when all of the processes under test crashed out from under us and we tried to print extra info to help debug the test failure, but at least one of the processes had no output

Apply internal fixes and improvements to public repo

- use the 'source' option for coverage to pick up files not touched by any test. Currently, message_pump and apex_launchtest_ros/__init__.py because we're not running any of the ROS examples

Add coverage on 0% covered files

Signed-off-by: William Woodall <[email protected]>

wjwwood · 2019-03-20T18:47:21Z

CI (full run):

Linux
Linux-aarch64
macOS
Windows

wjwwood · 2019-03-20T18:54:05Z

I'll be merging this without the DCO checker passing because the commits predate our policy, however, I will ask @dejanpan and @pbaughman to just confirm in a comment, that they would have signed-off for the commits that lack the sign-off in the commit message.

hidmic · 2019-03-20T20:09:21Z

apex_rostest/README.md

@@ -0,0 +1,129 @@
+# apex_launchtest


Just as a reminder for our future selves, we need to find a new home for this repo level README.

hidmic · 2019-03-20T20:12:06Z

apex_rostest/apex_launchtest/setup.cfg

@@ -0,0 +1,4 @@
+[coverage:run]


Hmm, we don't do coverage checks, do we? Just wondering if it'd make sense to bring that improvement along with the repo.

We don't collect coverage stats right now in our CI, but it would be nice to have this at some point. I don't know, however, if putting it in the setup.cfg makes sense, as it should be possible to run it with and without. I don't know what the recommended strategy is.

My understanding is that a bunch of different tools may look for a setup.cfg file and should each ignore configuration sections not meant for them. If this is causing a problem with another tool that expects its setup.cfg file to be free of [coverage:run] sections, we could also move it to a file called .coveragerc

See https://coverage.readthedocs.io/en/v4.5.x/config.html for how 'coverage' uses configuration files

hidmic · 2019-03-20T20:12:52Z

apex_rostest/apex_launchtest/setup.py

@@ -0,0 +1,30 @@
+#!/usr/bin/env python


Shouldn't be python3 instead?

It probably shouldn't have a shebang.

wjwwood · 2019-03-20T20:18:43Z

We should address the comments you raised when merging it with the existing code, i.e. after this import pr.

pbaughman · 2019-03-20T22:27:23Z

@wjwwood - I confirm that I would've signed off on the commits that lack the sign-off in the commit message

wjwwood · 2019-03-20T23:46:50Z

Thanks @pbaughman for the confirmation.

The CI failures are the know test_cli.test_param_yaml tests.

@dejanpan just waiting for you to 👍 the commits that weren't signed-off at the time.

dejanpan · 2019-03-21T18:55:26Z

@wjwwood - I confirm that I would've signed off on the commits that lack the sign-off in the commit message

dirk-thomas · 2020-07-07T19:36:25Z

apex_rostest/apex_launchtest_cmake/cmake/add_apex_launchtest.cmake

+#  This file contains modified code from the following open source projects
+#  published under the licenses listed below:
+
+# Software License Agreement (BSD License)


@wjwwood This doesn't match the license declared in the manifest?

dejanpan and others added 30 commits January 31, 2019 17:47

Initial commit

8ff3662

First version of integration test framework based on roslaunch2

feac5bb

Add launch arguments to apex_rostest

a90525d

- Arguments work like regular launch arguments: apex_rostest name_of_test.py arg:=foo - Added a mesasge pump class that will spin some rclpy nodes on a background thread automatically

Merge pull request #1 from ApexAI/launch_arguments

935b8b2

Add launch arguments to apex_rostest

Make sequential output checker public

9e41f8c

Use the print_arguments_of_launch_description function from ros2launc…

19da06f

…h API

Add arg support to apex_rostest_cmake

c1aec4c

Add more information to the junit XML

c19c4da

Address PR comments

2155b1d

Address Dejan's review comments

fe0cd07

Merge pull request #6 from ApexAI/refactor_ros

7be0c79

Change apex_rostest to apex_launchtest

Enable gitlab CI

3fc30c8

- Build and test apex_launchtest only - Build and test everything (apex_launchtest + apex_launchtest_ros) - Coverage report

Speed up the 'coverage' job

13801e7

Address Hao's PR comments

0a35904

- Git rid of extra sh -c (left over from a copy/paste) - Build jobs only save 'build' and 'install' artifacts - test_all job saves 'build', 'install', 'log', and globs for .coverage files

Merge pull request #8 from ApexAI/add_ci

e9d2c75

Add gitlab ci

Give extra information when processes die before tests are done

54a14b9

Fix coverage report

17fadd6

- Use symlink-install, otherwise coverage we get through subprocess calls ends up in a different place than coverage we get through calling functions directly from tests

Merge pull request #15 from ApexAI/fix_coverage

3cdf135

Fix coverage report

Merge pull request #12 from ApexAI/more_output_when_node_dies

0563221

More output when node dies

Have IO and Exit Code asserts use the same lookup

2fe94cf

- Gave all of these methods the same signature. They can all take ExecuteProcess actions or strings - New util to handle the lookup of process actions in one place

Address wjwwood's review comments

7ad1693

Merge pull request #16 from ApexAI/ISSUE7_simplify_asserts

e0f07a2

Have IO and Exit Code asserts use the same lookup

Docs and examples (#10)

bf5a371

* Initial README.md doc and improved example * Address review comments * Describe assertions * Describe arguments * Address second round of review comments * Update README.md One more round of addressing comments

Simple XML output check

09a7d9b

Merge pull request #11 from ApexAI/test_xml_output

3233d79

Test xml output

Remove rclpy dep

bc3fa5e

- Remove ros2launch dep from apex_launchtest, which should also remove rclpy dep - Add test for the '--show-args' argument - enable CI check for rclpy dep

Test we're compatible with ros-crystal

bcc3f71

Merge pull request #22 from ApexAI/ci_isolated_build

9403864

Remove rclpy from apex_launch

Pete Baughman and others added 12 commits March 14, 2019 11:57

Make isolated build schedule-only again

4e28ccd

Merge pull request #30 from ApexAI/debug_rclpy_dep

e4d3a53

Fix rclpy dep (again)

apex_launchtest_ros make MessagePump work with context

9520c7c

apex_launchtest_cmake give option to increase timeout

abf801d

apex_launchtest handle processes with no output

9ca67ef

- This bug happened when all of the processes under test crashed out from under us and we tried to print extra info to help debug the test failure, but at least one of the processes had no output

Add test for error process with no output

149b736

Merge pull request #31 from ApexAI/fixes_to_upstream

36493dc

Apply internal fixes and improvements to public repo

Add coverage on 0% covered files

b2de488

- use the 'source' option for coverage to pick up files not touched by any test. Currently, message_pump and apex_launchtest_ros/__init__.py because we're not running any of the ROS examples

Merge pull request #27 from ApexAI/cov_on_zero_percent_files

f8457a4

Add coverage on 0% covered files

reroot ApexAI repository into subfolder

4bd7eb6

Signed-off-by: William Woodall <[email protected]>

Merge remote-tracking branch 'origin/master' into import_apex_rostest

2b94aeb

disable imported code

01a5b53

Signed-off-by: William Woodall <[email protected]>

wjwwood self-assigned this Mar 20, 2019

wjwwood added the in progress Actively being worked on (Kanban column) label Mar 20, 2019

wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 20, 2019

wjwwood requested a review from hidmic March 20, 2019 18:55

wjwwood mentioned this pull request Mar 20, 2019

merging with ApexAI/apex_rostest and repository reorganization #208

Closed

29 tasks

hidmic approved these changes Mar 20, 2019

View reviewed changes

wjwwood merged commit 86f663d into master Mar 21, 2019

wjwwood deleted the import_apex_rostest branch March 21, 2019 18:56

wjwwood removed the in review Waiting for review (Kanban column) label Mar 21, 2019

dirk-thomas reviewed Jul 7, 2020

View reviewed changes

dirk-thomas mentioned this pull request Jul 13, 2020

clarify inconsistent license #439

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import apex rostest #209

Import apex rostest #209

wjwwood commented Mar 20, 2019

wjwwood commented Mar 20, 2019 •

edited

Loading

wjwwood commented Mar 20, 2019

hidmic Mar 20, 2019

hidmic Mar 20, 2019

wjwwood Mar 20, 2019

pbaughman Mar 20, 2019

hidmic Mar 20, 2019

wjwwood Mar 20, 2019

wjwwood commented Mar 20, 2019

pbaughman commented Mar 20, 2019

wjwwood commented Mar 20, 2019

dejanpan commented Mar 21, 2019

dirk-thomas Jul 7, 2020 •

edited

Loading

Import apex rostest #209

Import apex rostest #209

Conversation

wjwwood commented Mar 20, 2019

wjwwood commented Mar 20, 2019 • edited Loading

wjwwood commented Mar 20, 2019

hidmic Mar 20, 2019

Choose a reason for hiding this comment

hidmic Mar 20, 2019

Choose a reason for hiding this comment

wjwwood Mar 20, 2019

Choose a reason for hiding this comment

pbaughman Mar 20, 2019

Choose a reason for hiding this comment

hidmic Mar 20, 2019

Choose a reason for hiding this comment

wjwwood Mar 20, 2019

Choose a reason for hiding this comment

wjwwood commented Mar 20, 2019

pbaughman commented Mar 20, 2019

wjwwood commented Mar 20, 2019

dejanpan commented Mar 21, 2019

dirk-thomas Jul 7, 2020 • edited Loading

Choose a reason for hiding this comment

wjwwood commented Mar 20, 2019 •

edited

Loading

dirk-thomas Jul 7, 2020 •

edited

Loading