remove async launcher to fix #51 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
commented
Mar 21, 2017
| @@ -1,63 +0,0 @@ | |||
| # Copyright 2015 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
@dirk-thomas I couldn't figure out what these tests were trying to accomplish, so I couldn't determine how I might refactor it to still test this without the async launcher. Do you have any insight? My uneducated guess is that it can just be removed.
There was a problem hiding this comment.
Yeah, they can be removed for now together with the AsynchronousLauncher
dirk-thomas
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #51 (comment)
Fixes #51
CI: