Mention that ready_fn in generate_test_description is deprecated #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead. Signed-off-by: Bi0T1N <[email protected]>
clalancette
approved these changes
Jul 6, 2022
Signed-off-by: Chris Lalancette <[email protected]>
|
Since this is just a change to the README, I'm going to just go with the results from the Gpr job. I'll also backport this to Foxy. |
|
@Mergifyio backport foxy |
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Mention that ready_fn in generate_test_description is deprecated Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead. Signed-off-by: Bi0T1N <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit ef3c964)
✅ Backports have been created
|
clalancette
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Mention that ready_fn in generate_test_description is deprecated Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead. Signed-off-by: Bi0T1N <[email protected]@gmail.com> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit ef3c964)
clalancette
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Mention that ready_fn in generate_test_description is deprecated Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead. Signed-off-by: Bi0T1N <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit ef3c964)
clalancette
pushed a commit
that referenced
this pull request
Jul 6, 2022
… (#624) * Mention that ready_fn in generate_test_description is deprecated Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead. Signed-off-by: Bi0T1N <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit ef3c964) Co-authored-by: Bi0T1N <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foxy already shows:
Warning: Passing ready_fn as an argument to generate_test_description
will be removed in a future release. Include a
launch_testing.actions.ReadyToTest action in the LaunchDescription instead.
see #346
-> re-targeted version of #580