Skip to content

Commit

Permalink
Address security bug in yaml loading (#175)
Browse files Browse the repository at this point in the history
* Address security bug in yaml loading

Curate bug similar to ros/actionlib#171.
Connected with aliasrobotics/RVD#2401.

Signed-off-by: Víctor Mayoral Vilches <[email protected]>

* revert one of the changes

Signed-off-by: Dirk Thomas <[email protected]>

Co-authored-by: Dirk Thomas <[email protected]>
  • Loading branch information
vmayoral and dirk-thomas authored Aug 28, 2020
1 parent 066d8fe commit 38407ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_launch_ros/test/test_launch_ros/actions/test_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def test_launch_node_with_parameter_descriptions(self):
for item, is_file in expanded_parameter_arguments:
assert not is_file
name, value = item.split(':=')
parameters.append((name, yaml.load(value)))
parameters.append((name, yaml.safe_load(value)))
assert parameters == [
('param1', 'param1_value'),
('param2', ['param2', '_value']),
Expand Down

0 comments on commit 38407ba

Please sign in to comment.