Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for armv7l support. #15

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jan 7, 2021

Precisely what the title says. Connected to ros2/Mimick#16.

CI up to rclcpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic requested a review from brawner January 7, 2021 14:33
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are you making a separate PR for ros2/Mimick#17?

@hidmic
Copy link
Contributor Author

hidmic commented Jan 7, 2021

Looks good to me. Are you making a separate PR for ros2/Mimick#17?

Yes! I wanted to run CI for each separately.

@hidmic
Copy link
Contributor Author

hidmic commented Jan 7, 2021

Test failures are unrelated. Going in !

@hidmic hidmic merged commit 2136d97 into master Jan 7, 2021
@hidmic hidmic deleted the hidmic/update-mimick-tag branch January 7, 2021 21:39
@BrettRD BrettRD mentioned this pull request Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants