initialize memory before sending a message (#277)

* initialize memory before sending a message * add todo referencing ticket * wrap todo
ros2 · Aug 14, 2018 · 1e5bf4a · 1e5bf4a
1 parent e2f7c26
commit 1e5bf4a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/rcl/test/rcl/client_fixture.cpp b/rcl/test/rcl/client_fixture.cpp
@@ -158,6 +158,9 @@ int main(int argc, char ** argv)
 
     // Initialize a request.
     test_msgs__srv__Primitives_Request client_request;
+    // TODO(dirk-thomas) zero initialization necessary until
+    // https://github.com/ros2/ros2/issues/397 is implemented
+    memset(&client_request, 0, sizeof(test_msgs__srv__Primitives_Request));
     test_msgs__srv__Primitives_Request__init(&client_request);
     client_request.uint8_value = 1;
     client_request.uint32_value = 2;
@@ -178,6 +181,9 @@ int main(int argc, char ** argv)
 
     // Initialize the response owned by the client and take the response.
     test_msgs__srv__Primitives_Response client_response;
+    // TODO(dirk-thomas) zero initialization necessary until
+    // https://github.com/ros2/ros2/issues/397 is implemented
+    memset(&client_response, 0, sizeof(test_msgs__srv__Primitives_Response));
     test_msgs__srv__Primitives_Response__init(&client_response);
 
     if (!wait_for_client_to_be_ready(&client, 1000, 100)) {

diff --git a/rcl/test/rcl/service_fixture.cpp b/rcl/test/rcl/service_fixture.cpp
@@ -125,6 +125,9 @@ int main(int argc, char ** argv)
 
     // Initialize a response.
     test_msgs__srv__Primitives_Response service_response;
+    // TODO(dirk-thomas) zero initialization necessary until
+    // https://github.com/ros2/ros2/issues/397 is implemented
+    memset(&service_response, 0, sizeof(test_msgs__srv__Primitives_Response));
     test_msgs__srv__Primitives_Response__init(&service_response);
     OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
       test_msgs__srv__Primitives_Response__fini(&service_response);
@@ -139,6 +142,9 @@ int main(int argc, char ** argv)
 
     // Take the pending request.
     test_msgs__srv__Primitives_Request service_request;
+    // TODO(dirk-thomas) zero initialization necessary until
+    // https://github.com/ros2/ros2/issues/397 is implemented
+    memset(&service_request, 0, sizeof(test_msgs__srv__Primitives_Request));
     test_msgs__srv__Primitives_Request__init(&service_request);
     OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
       test_msgs__srv__Primitives_Request__fini(&service_request);