Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line static remapping (ROS1 compatible syntax + nodename prefix) #217

Merged
merged 85 commits into from
Mar 16, 2018
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
3f68319
rcl_node_namespace() implemented
sloretz Feb 2, 2018
d77489f
Committing whatever is there, todo rewrite history
sloretz Feb 27, 2018
d160ca6
INIT_GLOBAL_ARGS test macro
sloretz Feb 28, 2018
949feee
rcl_remap_namespace -> rcl_remap_node_namespace
sloretz Feb 28, 2018
cbea457
Test local arguments used for namespace replacement
sloretz Feb 28, 2018
6f22ea3
Split topic and service remapping functions
sloretz Feb 28, 2018
896af8b
Test topic remap using local arugments
sloretz Feb 28, 2018
f50dde1
Terminate copied string with \0. Add service remap tests
sloretz Feb 28, 2018
55b17e6
Refactored remap rule parsing and application
sloretz Mar 1, 2018
5bd5106
Nodename replacement tests with validation fix
sloretz Mar 1, 2018
4a0ed73
Tests for rules with node-name prefixes
sloretz Mar 1, 2018
f4a23d0
Support remap rules with relative names
sloretz Mar 2, 2018
bbf2b15
Remove comment
sloretz Mar 2, 2018
b811a4f
Check allocator before using it
sloretz Mar 2, 2018
f12280d
uncrustify
sloretz Mar 2, 2018
4db3285
Remove out of date TODO
sloretz Mar 2, 2018
e21795a
rcl_node_init remaps node name
sloretz Mar 2, 2018
9c03f7a
Namespace remapping works. Fix logger name not being remapped
sloretz Mar 2, 2018
ad7790a
Node name and namespace obeys use_global_arguments
sloretz Mar 2, 2018
342c36a
rcl_node_init remaps using arguments supplied to options
sloretz Mar 2, 2018
0f2e2f2
Added failing tests for publisher topic remapping
sloretz Mar 3, 2018
f324e45
Publisher topic name can be remapped
sloretz Mar 5, 2018
f8bfd8e
Add tests for subscriber
sloretz Mar 5, 2018
1fa0f74
Subscription obeys remap rules
sloretz Mar 5, 2018
6e445fd
Client service name can be remapped
sloretz Mar 5, 2018
aecfb79
Service service can now be remapped
sloretz Mar 5, 2018
7b95137
Fix crash on invalid namespace
sloretz Mar 5, 2018
0484332
Fix leaks reported by ASAN
sloretz Mar 5, 2018
8023a33
Shorten sentence
sloretz Mar 7, 2018
21d0311
Shorten sentence
sloretz Mar 7, 2018
f04ed71
wrong param documentation
sloretz Mar 7, 2018
39214bd
Expand field documentation in node_options
sloretz Mar 7, 2018
d661f36
Fix parameter documentation
sloretz Mar 7, 2018
bd0b481
null local arguments and use_global_options false is invalid
sloretz Mar 7, 2018
f146ae9
Function documentation
sloretz Mar 7, 2018
ea03e51
RCL_LOCAL
sloretz Mar 7, 2018
0355ff5
RCL_LOCAL + documentation
sloretz Mar 7, 2018
de189e1
Doc + exit early if colon in replacement
sloretz Mar 7, 2018
3852c82
Comment
sloretz Mar 7, 2018
f86af0e
Swap lhs and rhs in comparison
sloretz Mar 7, 2018
25d5340
Add functions to get unparsed arguments
sloretz Mar 7, 2018
62c8154
Fix validation of match and replacement, test unparsed args functions
sloretz Mar 7, 2018
d74e537
Check that colon is not NULL
sloretz Mar 7, 2018
1b6cb90
consolidate tests for arguments
sloretz Mar 7, 2018
d971b01
Fix '/' not seen as a valid namespace
sloretz Mar 7, 2018
582ff8d
Change comparision
sloretz Mar 7, 2018
d2c2d68
Better cleanup in failure cases
sloretz Mar 7, 2018
a8528f2
Fix comment
sloretz Mar 8, 2018
6a59c19
fix leak in fini
sloretz Mar 8, 2018
97f68b4
Smarter arg macros
sloretz Mar 8, 2018
c7c52e7
Split remapping tests
sloretz Mar 8, 2018
65273b1
Fix windows error array of len 0
sloretz Mar 8, 2018
f5618ca
style
sloretz Mar 8, 2018
09dd51f
fix windows warning about strncpy
sloretz Mar 8, 2018
49fcf13
Fix windows warnings about data loss
sloretz Mar 8, 2018
b9c64fb
Remove memory_tools
sloretz Mar 8, 2018
2083bf3
Shorten test code
sloretz Mar 8, 2018
0f7c344
Rename fixture
sloretz Mar 8, 2018
b76273c
blank lines
sloretz Mar 8, 2018
b9f0108
Document arguments_impl
sloretz Mar 8, 2018
b6c056e
Remove memorytools
sloretz Mar 8, 2018
60d7747
style
sloretz Mar 8, 2018
51df697
Style
sloretz Mar 8, 2018
7963397
Consistent punctuation in comments
sloretz Mar 14, 2018
a98baf2
indentation and vertical whitespace
sloretz Mar 14, 2018
a78266c
Make name argument more specific
sloretz Mar 14, 2018
6ac891f
remap rules and arguments store allocator, and fini fixes
sloretz Mar 14, 2018
6dbab0f
Declaritive \brief
sloretz Mar 14, 2018
015bff1
Add method to get global CLI args
sloretz Mar 14, 2018
0ad0f63
Rename two functions to start with rcl_arguments_
sloretz Mar 14, 2018
129aeb7
-1 if args is NULL or zero initialized
sloretz Mar 14, 2018
d08034b
Sorted includes
sloretz Mar 14, 2018
b52bb8b
are -> as
sloretz Mar 14, 2018
0b465df
remap functions accept global args instead of bool
sloretz Mar 14, 2018
21b9806
use rcutils_reallocf
sloretz Mar 15, 2018
42ea8df
Print error message if fini fails in error handling
sloretz Mar 15, 2018
12e5f59
Improved error messages in _rcl_parse_remap_rule
sloretz Mar 15, 2018
21227ca
Remove out of date comment
sloretz Mar 15, 2018
a58b71f
const argv
sloretz Mar 15, 2018
c04c2eb
expand docs on remapping and argument parsing
sloretz Mar 15, 2018
1925221
Use rmw_validate_node_name_with_size
sloretz Mar 15, 2018
4f5180f
Better error messages for arg parsing
sloretz Mar 15, 2018
8cbe7f8
Flatten logic and better error handling while remapping
sloretz Mar 15, 2018
3aa044a
Merge branch 'master' into impl_static_remapping
sloretz Mar 15, 2018
6f39edf
use rcl_validate_topic_name_with_size
sloretz Mar 15, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into impl_static_remapping
sloretz committed Mar 15, 2018
commit 3aa044aee1ff1e506c633f27653acd73735828f7

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.