Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static remapping with single token wildcard, url schemes, and backreferences #226

Closed

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Apr 6, 2018

WIP static remapping with wildcards, url scheme, and backreferences. I'm creating this PR to have a place to copy/paste CI results.

Done

  • Lexer
  • Lookahead (2) buffer on top of lexer

Todo

  • Parser
  • Update contents of rcl_remap_t
  • Update name matching logic
  • Update name replacement logic

Connects to ros2/ros2#450

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Apr 6, 2018
@sloretz sloretz added this to the bouncy milestone Apr 6, 2018
@sloretz sloretz self-assigned this Apr 6, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Apr 6, 2018

Build Status (windows)

@sloretz
Copy link
Contributor Author

sloretz commented Apr 9, 2018

Closing. I'm splitting the features (again). #227 does URL scheme, a PR after that will add single-token wildcard and backreferences, and a PR after that will add multi-token wild cards.

@sloretz sloretz closed this Apr 9, 2018
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label Apr 9, 2018
@sloretz sloretz deleted the static_remapping_wildcard_url_scheme_backreferences branch April 9, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant