Add action services and topics name getters #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobperron could you launch a CI job on this one? It seems I still don't have enough powers to do that. |
jacobperron
reviewed
Oct 31, 2018
There was a problem hiding this comment.
There might be conflicts with CMakeLists.txt when I merge #312, but I guess there's not much we can do about that.
sloretz
reviewed
Oct 31, 2018
hidmic
force-pushed
the
hidmic/action-names
branch
from
e9b7787 to
55d83f2
Compare
|
CI (build flags:
|
|
Alright! All green, merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #306. This pull request introduces basic utility functions to avoid duplicating action service and topic names computations in both client and server implementations.