Workaround for the change in libnddscore.so in connext 5.2.0 between gcc4.6.3 and gcc4.8.2 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gcc4.6.3 and gcc4.8.2
| if(NOT "${ARGN} " STREQUAL " ") | ||
| message(FATAL_ERROR "append_link_flags() called with " | ||
| "unused arguments: ${ARGN}") | ||
| endif() |
There was a problem hiding this comment.
Since this is a local macro which is not used externally I would not bother with this check and save the four lines.
dhood
force-pushed
the
connext-workaround
branch
from
69de08c to
2ae8819
Compare
|
lgtm |
|
lgtm too |
|
With Connext 5.2.3 on Xenial I needed the same patch for these targets (note all failing targets are ending with
I don't know why only for those targets are affected and not for the others. And therefore I hesitate to apply the same patch in these cases. Since the RTI Connext release notes mentioned that |
emersonknapp
pushed a commit
to aws-ros-dev/rcl
that referenced
this pull request
Jun 3, 2019
…s2#55) * Don't try to interrupt an exiting process * Remove unnecessary get_default_filtered_prefixes usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52, which I currently understand to be caused by the connext 5.2.0 package labelled as built with gcc4.8.2 not exporting a dependency on
dl(in contrast to the one labelled with gcc4.6.3).The executables do have
-ldlin the linking stage, but--no-as-neededis needed to ensure that the linking actually happens.Adding a
dlopen(NULL, RTLD_NOW);call to theservice_fixtureandclient_fixturefiles is an alternative workaround because it forcesdlto not be considered unneeded.No regressions that I can see
http://ci.ros2.org/job/ci_linux/1243/
http://ci.ros2.org/job/ci_windows/1281/
http://ci.ros2.org/job/ci_osx/998/