Fix yaml parser error when meets .nan (refactor on #754) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ada-King <[email protected]> Correct code style Signed-off-by: Ada-King <[email protected]> Modify as suggested Signed-off-by: Ada-King <[email protected]> Improve test Signed-off-by: Ada-King <[email protected]> Fix minor flaw Signed-off-by: Ada-King <[email protected]> Fix minor flaw again Signed-off-by: Ada-King <[email protected]> Satisfy windows CI Signed-off-by: Ada-King <[email protected]> Change the match rule for special float Signed-off-by: Ada-King <[email protected]> Distinguish +.inf and -.inf Signed-off-by: Ada-King <[email protected]>
brawner
changed the title
fujitatomoya
approved these changes
Sep 1, 2020
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
reviewed
Sep 2, 2020
There was a problem hiding this comment.
This looks generally good to me. The one exception is that there are failing tests in the PR job. @brawner are these currently expected?
|
@clalancette, the rpr job has failures in Testing
|
|
This passes CI for both rcl_yaml_param_parser and rcl. Thanks @Ada-King for the patch! |
|
This will need a backport, but will be dependent on the backport of #754. |
brawner
added a commit
that referenced
this pull request
Sep 2, 2020
* Fix yaml parser error when meets .nan Signed-off-by: Ada-King <[email protected]> Correct code style Signed-off-by: Ada-King <[email protected]> Modify as suggested Signed-off-by: Ada-King <[email protected]> Improve test Signed-off-by: Ada-King <[email protected]> Fix minor flaw Signed-off-by: Ada-King <[email protected]> Fix minor flaw again Signed-off-by: Ada-King <[email protected]> Satisfy windows CI Signed-off-by: Ada-King <[email protected]> Change the match rule for special float Signed-off-by: Ada-King <[email protected]> Distinguish +.inf and -.inf Signed-off-by: Ada-King <[email protected]> * Remove unnecessary #include change. Signed-off-by: Chris Lalancette <[email protected]> * Add in two more necessary includes. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Ada-King <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
brawner
added a commit
that referenced
this pull request
Oct 6, 2020
* Fix yaml parser error when meets .nan Signed-off-by: Ada-King <[email protected]> Correct code style Signed-off-by: Ada-King <[email protected]> Modify as suggested Signed-off-by: Ada-King <[email protected]> Improve test Signed-off-by: Ada-King <[email protected]> Fix minor flaw Signed-off-by: Ada-King <[email protected]> Fix minor flaw again Signed-off-by: Ada-King <[email protected]> Satisfy windows CI Signed-off-by: Ada-King <[email protected]> Change the match rule for special float Signed-off-by: Ada-King <[email protected]> Distinguish +.inf and -.inf Signed-off-by: Ada-King <[email protected]> * Remove unnecessary #include change. Signed-off-by: Chris Lalancette <[email protected]> * Add in two more necessary includes. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Ada-King <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
brawner
added a commit
that referenced
this pull request
Oct 6, 2020
* Fix yaml parser error when meets .nan Signed-off-by: Ada-King <[email protected]> Correct code style Signed-off-by: Ada-King <[email protected]> Modify as suggested Signed-off-by: Ada-King <[email protected]> Improve test Signed-off-by: Ada-King <[email protected]> Fix minor flaw Signed-off-by: Ada-King <[email protected]> Fix minor flaw again Signed-off-by: Ada-King <[email protected]> Satisfy windows CI Signed-off-by: Ada-King <[email protected]> Change the match rule for special float Signed-off-by: Ada-King <[email protected]> Distinguish +.inf and -.inf Signed-off-by: Ada-King <[email protected]> * Remove unnecessary #include change. Signed-off-by: Chris Lalancette <[email protected]> * Add in two more necessary includes. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Ada-King <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Stephen Brawner <[email protected]>
brawner
added a commit
that referenced
this pull request
Oct 6, 2020
* Fix yaml parser error when meets .nan Signed-off-by: Ada-King <[email protected]> Correct code style Signed-off-by: Ada-King <[email protected]> Modify as suggested Signed-off-by: Ada-King <[email protected]> Improve test Signed-off-by: Ada-King <[email protected]> Fix minor flaw Signed-off-by: Ada-King <[email protected]> Fix minor flaw again Signed-off-by: Ada-King <[email protected]> Satisfy windows CI Signed-off-by: Ada-King <[email protected]> Change the match rule for special float Signed-off-by: Ada-King <[email protected]> Distinguish +.inf and -.inf Signed-off-by: Ada-King <[email protected]> * Remove unnecessary #include change. Signed-off-by: Chris Lalancette <[email protected]> * Add in two more necessary includes. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Ada-King <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Stephen Brawner <[email protected]> Co-authored-by: Ada-King <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased squash of #741. See that discussion for comments about the files. This PR was rebased and squashed into one commit after merging #754.
Fixes #555
Signed-off-by: Ada-King [email protected]
Correct code style
Signed-off-by: Ada-King [email protected]
Modify as suggested
Signed-off-by: Ada-King [email protected]
Improve test
Signed-off-by: Ada-King [email protected]
Fix minor flaw
Signed-off-by: Ada-King [email protected]
Fix minor flaw again
Signed-off-by: Ada-King [email protected]
Satisfy windows CI
Signed-off-by: Ada-King [email protected]
Change the match rule for special float
Signed-off-by: Ada-King [email protected]
Distinguish +.inf and -.inf
Signed-off-by: Ada-King [email protected]