[foxy backport] Refactor parser.c for better testability (#754) #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brawner
changed the title
brawner
force-pushed
the
brawner/rcl_yaml-backport-780
branch
from
2798b69 to
1c31fe4
Compare
* Refactor rcl_yaml_param_parser for better testability Signed-off-by: Stephen Brawner <[email protected]> * Reorder parser.c to match parser.h Signed-off-by: Stephen Brawner <[email protected]> squash! Reorder parser.c to match parser.h * Refactor yaml_variant.c for deduplication Signed-off-by: Stephen Brawner <[email protected]> * ADD_VALUE_TO_SIMPLE_ARRAY for deduplication Signed-off-by: Stephen Brawner <[email protected]> * Remove fprintf Signed-off-by: Stephen Brawner <[email protected]> * PR Fixup Signed-off-by: Stephen Brawner <[email protected]> * Move headers to src directory Signed-off-by: Stephen Brawner <[email protected]> * PR Fixup Signed-off-by: Stephen Brawner <[email protected]> * Rebase #780 Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/rcl_yaml-backport-754
branch
from
c5b70a9 to
31df555
Compare
|
|
@ros-pull-request-builder retest this please |
|
@brawner I'm not sure why the Fpr job is failing but manually triggered CI looks okay. |
|
It might be a missing include that get's picked up in the CI job? I'll try digging into this |
brawner
force-pushed
the
brawner/rcl_yaml-backport-754
branch
from
0e978e9 to
5f9bf07
Compare
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/rcl_yaml-backport-754
branch
2 times, most recently
from
d437319 to
8f52813
Compare
|
Added the missing includes to get the Fpr job to pass.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #754
This one needs to be ABI checked
Signed-off-by: Stephen Brawner [email protected]