Added preallocate test messages #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo de Pedro <[email protected]>
gonzodepedro
force-pushed
the
gonzalodepedro/rmw_preallocate
branch
from
b5d5363 to
bc91ad9
Compare
|
I'm curious why the existing test messages are not sufficient. What case(s) are not covered by the existing messages? |
|
I think that the existing ones are sufficient, and that this may not have been needed. I think it was for additional testing to make sure that allocations didn't happen on larger bounded messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro [email protected]
Add test_messages required for memory preallocation testing
Connects to /ros2/rmw_connext#346 and /ros2/rmw_connext#345