Apply suggestions from code review

Co-authored-by: Tomoya Fujita <[email protected]>
ros2 · Aug 22, 2023 · c6edffa · c6edffa
1 parent 947d469
commit c6edffa
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/rclcpp_action/test/test_client.cpp b/rclcpp_action/test/test_client.cpp
@@ -899,7 +899,7 @@ TEST_F(TestClientAgainstServer, deadlock_in_callbacks)
       dual_spin_until_future_complete(future_goal_handle);
       auto goal_handle = future_goal_handle.get();
 
-      EXPECT_TRUE(goal_handle);
+      ASSERT_TRUE(goal_handle);
 
       ASSERT_EQ(RCL_RET_OK, rcl_set_ros_time_override(clock.get_clock_handle(), RCL_S_TO_NS(2)));
 
@@ -923,6 +923,7 @@ TEST_F(TestClientAgainstServer, deadlock_in_callbacks)
   // in case of a failure, we don't want to block further tests
   tr.detach();
 
+  EXPECT_TRUE(test_done);
   EXPECT_TRUE(response_callback_called);
   EXPECT_TRUE(result_callback_called);
   EXPECT_TRUE(feedback_callback_called);