Use const on getters

ros2 · Apr 8, 2015 · ded15cf · ded15cf
1 parent 0ce0898
commit ded15cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/rclcpp/include/rclcpp/node.hpp b/rclcpp/include/rclcpp/node.hpp
@@ -111,13 +111,13 @@ class Node
     rclcpp::callback_group::CallbackGroup::SharedPtr group=nullptr);
 
   template <typename ParamTypeT>
-  ParamTypeT get_param(const parameter::ParamName& key);
+  ParamTypeT get_param(const parameter::ParamName& key) const;
 
   std::vector<parameter::ParamContainer>
-  get_params(const std::vector<parameter::ParamQuery>& query);
+  get_params(const std::vector<parameter::ParamQuery>& query) const;
 
   bool
-  has_param(const parameter::ParamQuery& query);
+  has_param(const parameter::ParamQuery& query) const;
 
   template <typename ParamTypeT>
   void set_param(const parameter::ParamName& key, const ParamTypeT& value);

diff --git a/rclcpp/include/rclcpp/node_impl.hpp b/rclcpp/include/rclcpp/node_impl.hpp
@@ -236,9 +236,9 @@ Node::create_service(
 
 template <typename ParamTypeT>
 ParamTypeT
-Node::get_param(const parameter::ParamName& key)
+Node::get_param(const parameter::ParamName& key) const
 {
-  parameter::ParamContainer pc = this->params_[key];
+  const parameter::ParamContainer pc = this->params_.at(key);
   ParamTypeT value;
   return pc.get_value<ParamTypeT>(value);
 }
@@ -253,14 +253,14 @@ Node::set_param(const parameter::ParamName& key, const ParamTypeT& value)
 }
 
 bool
-Node::has_param(const parameter::ParamQuery& query)
+Node::has_param(const parameter::ParamQuery& query) const
 {
   const parameter::ParamName key = query.get_name();
   return (params_.find(key) != params_.end());
 }
 
 std::vector<parameter::ParamContainer>
-Node::get_params(const std::vector<parameter::ParamQuery>& queries)
+Node::get_params(const std::vector<parameter::ParamQuery>& queries) const
 {
   std::vector<parameter::ParamContainer> result;