added get_type_name and to_string to ParameterVariant #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| switch (get_type()) { | ||
| case rclcpp::parameter::ParameterType::PARAMETER_BOOL: | ||
| return "bool"; | ||
| break; |
There was a problem hiding this comment.
These break statements are unreachable and should be removed.
Same below.
|
+1 |
wjwwood
force-pushed
the
refactor_examples_and_interfaces
branch
from
c7e930a to
f8d5f4a
Compare
|
Ok, I addressed the comments and squashed. |
| case rclcpp::parameter::ParameterType::PARAMETER_NOT_SET: | ||
| return "not set"; | ||
| default: | ||
| throw std::runtime_error("Unexpected type from ParameterVariant"); |
There was a problem hiding this comment.
Should the error string include the actual numeric value of get_type()?
Same below.
There was a problem hiding this comment.
I'm not sure that's very useful, but I'll include it.
wjwwood
force-pushed
the
refactor_examples_and_interfaces
branch
from
f8d5f4a to
40aa065
Compare
this was done to enable a more concise example
wjwwood
force-pushed
the
refactor_examples_and_interfaces
branch
from
40aa065 to
e75c1d0
Compare
|
+1 |
wjwwood
added a commit
that referenced
this pull request
Jun 19, 2015
added get_type_name and to_string to ParameterVariant
| bool first_byte = true; | ||
| bytes << "[" << std::hex; | ||
| for (auto & byte : as_bytes()) | ||
| { |
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Feb 15, 2021
Ctests fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done to enable more concise parameter examples.
I'm open to suggestion on a more elegant way to do the bytes to_string within a switch statement.
Connects to ros2/examples#4