Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO for OpenSplice DDS issue. #1354

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

fujitatomoya
Copy link
Collaborator

minor cosmetic fix to remove TODO for https://github.com/ros2/rmw_opensplice

Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment removed, does not require CI.

rclpy/test/test_messages.py Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with either green CI or a green Rpr job.

@fujitatomoya fujitatomoya merged commit d410670 into rolling Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants