-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds wait_for_node #930
Adds wait_for_node #930
Conversation
Signed-off-by: Gonzalo de Pedro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've left a bunch of minor comments below.
Signed-off-by: Gonzalo de Pedro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the test is fixed.
Signed-off-by: Gonzalo de Pedro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobperron are you planning to pick this up from Gonzo? |
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor suggestions.
LGTM!
@jacobperron friendly ping |
Signed-off-by: Jacob Perron <[email protected]>
missed these in the previous refactor Signed-off-by: Jacob Perron <[email protected]>
Related #823
Signed-off-by: Gonzalo de Pedro [email protected]