Make sure that an existing path is a directory for create_directories #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
|
I'll look into that Windows failure. |
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
force-pushed
the
fs-create-directories-check-if-dir
branch
from
1821c75 to
5675cdb
Compare
|
Trying something quickly, but if that doesn't work I'll have to actually try on Windows.
|
|
Not exactly sure why, but it looks like that did the trick. We don't really need to check if the path is a directory at every step/recursively, since the next step will just fail if it's not a directory anyway. I'll let you decide if you want to re-run CI on all platforms. |
wjwwood
approved these changes
Sep 22, 2020
fujitatomoya
added a commit
to fujitatomoya/rcpputils
that referenced
this pull request
Sep 25, 2020
fujitatomoya
added a commit
to fujitatomoya/rcpputils
that referenced
this pull request
Sep 25, 2020
…eate_directories (ros2#95)" (ros2#96)" This reverts commit ba5d1e4. Signed-off-by: Tomoya.Fujita <[email protected]>
This was referenced Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the final/complete path already exists, make sure that it is a directory.
I've also added a line in the relevant test.
Fixes #94