Indicate missing support for unique network flows #484
Conversation
Signed-off-by: Ananya Muddukrishna <[email protected]>
Signed-off-by: Ananya Muddukrishna <[email protected]>
Signed-off-by: Ananya Muddukrishna <[email protected]>
Signed-off-by: Ananya Muddukrishna <[email protected]>
| // limitations under the License. | ||
|
|
||
| #include "rmw/error_handling.h" | ||
| #include "rmw/get_network_flow_endpoint.h" |
There was a problem hiding this comment.
| #include "rmw/get_network_flow_endpoint.h" | |
| #include "rmw/get_network_flow_endpoints.h" |
The name of the file looks wrong
https://github.com/Ericsson/ros2-rmw/blob/c1c25072c199c3177121768a612243386b84b054/rmw/include/rmw/get_network_flow_endpoints.h#L1 (?)
There was a problem hiding this comment.
@ivanpauno Thanks for noticing the mistake. I understood that this repository is going to be deprecated so did not include it in my integration recent tests with Rolling Ridley. Also, the ros2.repos file for Rolling Ridley does not include this repository.
Since this PR got merged, do I go ahead and create a new PR to fix the error?
There was a problem hiding this comment.
Since this PR got merged, do I go ahead and create a new PR to fix the error?
Yes, thanks!
We don't need to continue adding new features here, but if we do we shouldn't break it.
(I know that there are people still using this package).
There was a problem hiding this comment.
I submitted a PR with corrections. Sorry about overlooking this.
Please ensure that it passes compile-time checks and does not break existing functionality. I am unable to test fully due to lack of a licensed RTI Connext system at my side.
This PR indicates missing support in rmw_connext for unique network flows for publishers and subscribers in communicating nodes. Such indication is required for graceful error handling in the ROS2 RMW and above layers.
Associated pull-requests:
Initial contributions stem from Ericsson and eProsima.
Signed-off-by: Ananya Muddukrishna [email protected]