Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update includes after rcutils/get_env.h deprecation #312

Merged

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Apr 30, 2021

ros2/rcutils#340 deprecates rcutils/get_env.h. This PR doesn't need to wait until the rcutils PR is merged, though.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — a bit superfluous, I'd say, after @clalancette's approval.

@christophebedard
Copy link
Member Author

CI from ros2/rcutils#340 (comment), building & testing everything:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 8857f2d into ros2:master May 4, 2021
@christophebedard christophebedard deleted the deprecate-rcutils-get-env-header branch May 4, 2021 14:31
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants