Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet 2.89 -> Bullet 3.17 #2351

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 15, 2022

Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz self-assigned this Mar 15, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this change for Rolling, as-is, is fine.

But it does make me wonder what our advice is for Foxy and Galactic users. Should they still download these latest packages? Or should we have them download the previous bullet 2.89.0?

@nuclearsandwich
Copy link
Member

So this change for Rolling, as-is, is fine.

But it does make me wonder what our advice is for Foxy and Galactic users. Should they still download these latest packages? Or should we have them download the previous bullet 2.89.0?

Assuming that CI passes when ros-infrastructure/ros2-cookbooks#42 is applied to ros2/ci and we run extra CI to cover Foxy and Galactic, I think we want our dev instructions to do what CI does and use the latest version. We don't have any kind of update guide / upgrade strategy for ROS 2 on Windows. Everything assumes a from-scratch setup but according to sloretz here the currently packaged version of bullet is fine for all ROS 2 use cases.

If we do want to deviate on Windows, ros-infrastructure/ros2-cookbooks#42 will need to be updated to conditionally change packages per rosdistro.

@sloretz
Copy link
Contributor Author

sloretz commented Mar 22, 2022

So this change for Rolling, as-is, is fine.

But it does make me wonder what our advice is for Foxy and Galactic users. Should they still download these latest packages? Or should we have them download the previous bullet 2.89.0?

Assuming that CI passes when ros-infrastructure/ros2-cookbooks#42 is applied to ros2/ci and we run extra CI to cover Foxy and Galactic, I think we want our dev instructions to do what CI does and use the latest version. We don't have any kind of update guide / upgrade strategy for ROS 2 on Windows. Everything assumes a from-scratch setup but according to ros2/choco-packages#18 (comment) the currently packaged version of bullet is fine for all ROS 2 use cases.

CI passed for Rolling, Galactic, and Foxy in ros-infrastructure/ros2-cookbooks#42 , so it and this one are ready to be merged. The documentation PR should be backported to Foxy and Galactic.

@sloretz sloretz merged commit b0bb173 into ros2:rolling Mar 29, 2022
@sloretz sloretz deleted the sloretz__bullet_3.17 branch March 29, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants