Fix interference between test_tracetools and ros2lifecycle tests #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #94
Relates to #95, but is still separate
test_tracetools
'stest_lifecycle_node
test andros2lifecycle
'stest_cli
test can interfere with each other if run in parallel, making one of them -- or both of them -- fail. For example,test_tracetools
fails in this nightly job here: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2988/.This is mainly because both tests use a lifecycle node with the same name and without any specific namespace:
test_tracetools
'stest_lifecycle_node
test usestest_lifecycle_node
ros2lifecycle
'stest_cli
test usesros2lifecycle_test_fixtures
'ssimple_lifecycle_node
, which is namedtest_lifecycle_node
This can lead to two separate failures:
test_tracetools
'stest_lifecycle_node
test timing out because the state machine ends up in a weird state (not sure why the timeouts intest_lifecycle_node.cpp
don't make it exit before the 60-second timeout, though)test_tracetools
'stest_lifecycle_node
test collects can include transitions fromros2lifecycle
The two separate solutions are:
/test_tracetools
) for the node intest_tracetools
'stest_lifecycle_node
test to avoid transition/topic-level interference