-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action send_goal prototype completer #301
Add action send_goal prototype completer #301
Conversation
4bc829a
to
09f6a08
Compare
44cff92
to
cf4649b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a minimal comment.
cf4649b
to
553b9b5
Compare
@ivanpauno I'll wait on your feedback and final approval of this PR before updating #299 & #300. |
6fb5b87
to
cea6e59
Compare
1b2bea4
to
421cba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artivis There's a linter failure, could you address it? Thanks! |
Sure thing ! |
Signed-off-by: artivis <[email protected]>
421cba8
to
1eeba50
Compare
@ivanpauno Should be fixed now. |
I tested locally, and linter is passing (and auto-completion continues working well). |
@artivis another minimal comment: try to avoid force pushing if it's not completely necessary, it does the review process harder. |
Add an action goal prototype completer to
ros2 action send_goal
.E.g.
Not very pretty but one can at least figure out the first few characters of the goal body.
Then,
resolves to,
This follows the work initiated in #298.
Signed-off-by: artivis [email protected]