-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Fix failing ros2param tests #632
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Well, it's finally passing. I have yet to explain why this FIN_WAIT_2 state timeout made all the difference though. FYI @ivanpauno. |
Alright, Ivan's still able to reproduce the failure. It appears it just made it less likely, so this won't do either. @clalancette @cottsay what shall we do for Galactic? We have:
Do we keep trying? Do we stick to a known issue and defer resolution? |
So the behavior that ros2cli will exhibit in Galactic is a flaky test, correct? How likely is it that an end-user would experience the bug "in the wild"? |
That depends on the implementation. With |
I would say that we should still try to debug this for Galactic, but as a relatively low priority. So far it seems unlikely that a user will hit this in real-life, so I think it is worthwhile to debug the problem and figure out what is really going on before we make further changes. |
Closing in favor of #652. |
CI up to
ros2param
andros2cli
: