Mark test verb load, list and dump as xfail #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
|
New CI marking TestCase subclass as xfail:
|
fujitatomoya
reviewed
Nov 2, 2022
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
|
New CI:
|
|
I think it still runs the tests: https://build.ros2.org/job/Gpr__ros2cli__ubuntu_focal_amd64/20/consoleFull#console-section-167 (Check ros2param test section) FYI: @cottsay Actually, they didn't run on CI build of the last comment. But they ran on https://build.ros2.org/job/Gpr__ros2cli__ubuntu_focal_amd64/20/. I'll fix the flake8 stuff in the next vcommit (again) |
Signed-off-by: Crola1702 <[email protected]>
|
New CI:
|
PR and release builds always run all tests. I think that |
cottsay
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this issue: #630, is reported an issue with this test on Humble, and @sloretz commented that the solution in #652, cannot be backported.
As this issue is happening just on galactic, I'm marking the following tests as xfail:
Reference build: https://build.ros2.org/view/Gci/job/Gci__nightly-debug_ubuntu_focal_amd64/179/
Running CI: