Use target_link_libraries instead of ament_target_dependencies #973
Conversation
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
There was a problem hiding this comment.
I think using pure CMake here is worth it because we can point users to CMake docs instead of our own, but I'm open to feedback.
i think this is okay, but we have lots of documentation that recommends ament_target_dependencies e.g https://docs.ros.org/en/rolling/How-To-Guides/Ament-CMake-Documentation.html#linking-to-dependencies. those can also be updated in the future.
|
Pulls: #973
|
This shows one weakness of
target_link_libraries: the target names are not automatically known.ament_cmakepackages create a_TARGETSvariable, so this CL makes the newament_cmakepackage script use that. There might be cases where a new package depending on a plain cmake library would have worked before withament_target_dependencies(), but does not work with this change.I think using pure CMake here is worth it because we can point users to CMake docs instead of our own, but I'm open to feedback.
ament/ament_cmake#292