-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing python3 dep #24
base: latest
Are you sure you want to change the base?
Conversation
Hi @cottsay, any chance to get a quick look at this? |
I put this on the infrastructure agenda to discuss on Monday, and I'll ping back here with any findings. I informally proposed the same change a few years back after stumbling across the same issue. Though I'm not involved or up-to-date on the effort, there is a desire for "python-free ROS 2" and even though some of the stuff in this package requires Python, this package can still be used without it. In the RPMs, I made Python a soft dependency: https://github.com/ros2-gbp/ros_workspace-release/blob/patches/rpm/rolling/ros_workspace/0001-Bootstrap-PYTHONPATH-and-inject-Python-3-dependency.patch Maybe we can do something similar for the debs. |
Well I guess that depends on one's definition of usable. If I can't source the ROS workspace this packages is meant to set up what is it good for? Note that there are entire dependency trees (certainly very few) that do not include python3 such as e.g. that of
Looking forward to next week ping back, |
Hi @cottsay, any updates on this? |
We had the periodic Infrastructure Team Office Hours in place of our weekly meeting this week. It will have to wait until next week. |
Hello, friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cottsay brought this up in today's meeting. In the past there was strong resistance to this because it introduces python at the lowest levels of the ROS package hierarchy, stymieing efforts to create a ROS 2 without Python installation.
It's unclear if any such efforts are still underway or using the apt packages for ROS 2 at all. I think that the user experience improvement of having python is strong enough to make it a required dependency.
If there is a need in the future we can always discuss patching the bloom package to put it into recommended/suggested (I forget which is the greater strength).
Closes #23 .