Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "Add additional mode of publishing sim time updates (#1036)" to rolling #1050

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Merge "Add additional mode of publishing sim time updates (#1036)" to rolling #1050

merged 3 commits into from
Jul 29, 2022

Conversation

kylemarcey
Copy link
Contributor

@kylemarcey kylemarcey commented Jul 28, 2022 •
edited by MichaelOrlov
Loading

Original PR #1036 targeted master and was overwritten by fa60ff7

@kylemarcey
Add new PlayOptions to control new method of /clock publishing
b2c4b61 
Signed-off-by: Kyle Marcey <[email protected]>
@kylemarcey
Add new arguments to ros2bag frontend to support publishing /clock up…
269bf00 
…dates triggered by replayed messages

Signed-off-by: Kyle Marcey <[email protected]>
@kylemarcey
Refactor rosbag2_transport::Player to allow two modes of publishing /…
647bb14 
…clock updates.

An additional mode of operation has been added to the Player class to allow for /clock updates. When this mode is active, /clock updates are triggered whenever messages are replayed rather than at a fixed rate. Optionally, a list of triggering topics can be set so that only a subset of replayed messages will trigger the /clock update.

This mode is most useful when replaying applications which do some sanity checking or correlation of message data to system timestamps. If the application does not need the sim time to be updated at a consistent rate, this mode can substantially reduce the overhead of having sim time enabled in rosbag2.

Signed-off-by: Kyle Marcey <[email protected]>
@kylemarcey kylemarcey marked this pull request as ready for review July 28, 2022 01:32
@kylemarcey kylemarcey requested a review from a team as a code owner July 28, 2022 01:32
@kylemarcey kylemarcey requested review from emersonknapp and hidmic and removed request for a team July 28, 2022 01:32
@MichaelOrlov MichaelOrlov self-requested a review July 28, 2022 01:33
@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented Jul 28, 2022 •
edited
Loading

Running CI:
Gist: https://gist.githubusercontent.com/MichaelOrlov/e277a0e08c5a0042b93b6bdc04e3c130/raw/4fd339c4316f300edd0b3824d5a7e0465a9bd9c3/ros2.repos
BUILD args: --packages-above-and-dependencies ros2bag rosbag2_py rosbag2_transport rosbag2_tests
TEST args: --packages-above ros2bag rosbag2_py rosbag2_transport rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10586

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

test_burst__rmw_fastrtps_dynamic_cpp failed with error

2022-07-28T02:21:11.9855933Z 59: /__w/rosbag2/rosbag2/ros_ws/src/42oufxecqtv/rosbag2/rosbag2_transport/test/rosbag2_transport/test_burst.cpp:366: Failure
2022-07-28T02:21:11.9856025Z 59: Value of: replayed_topic2
2022-07-28T02:21:11.9856123Z 59: Expected: size is equal to 3
2022-07-28T02:21:11.9856410Z 59:   Actual: { 16-byte object <10-55 E7-74 E1-55 00-00 00-55 E7-74 E1-55 00-00> }, whose size 1 doesn't match
2022-07-28T02:21:11.9856643Z 59: Failed to delete participant[  FAILED  ] RosBag2PlayTestFixture.burst_bursting_only_filtered_topics (10038 ms)
2022-07-28T02:21:11.9856875Z 59: [----------] 7 tests from RosBag2PlayTestFixture (11548 ms total)
2022-07-28T02:21:11.9859309Z 59: 
2022-07-28T02:21:11.9859519Z 59: [----------] Global test environment tear-down
2022-07-28T02:21:11.9859650Z 59: [==========] 7 tests from 1 test suite ran. (11548 ms total)
2022-07-28T02:21:11.9859734Z 59: [  PASSED  ] 6 tests.
2022-07-28T02:21:11.9859833Z 59: [  FAILED  ] 1 test, listed below:
2022-07-28T02:21:11.9860003Z 59: [  FAILED  ] RosBag2PlayTestFixture.burst_bursting_only_filtered_topics
2022-07-28T02:21:11.9860141Z 59: 
2022-07-28T02:21:11.9860219Z 59:  1 FAILED TEST
2022-07-28T02:21:11.9860364Z 59: -- run_test.py: return code 1
2022-07-28T02:21:11.9860823Z 59: -- run_test.py: inject classname prefix into gtest result file '/__w/rosbag2/rosbag2/ros_ws/build/rosbag2_transport/test_results/rosbag2_transport/test_burst__rmw_fastrtps_dynamic_cpp.gtest.xml'
2022-07-28T02:21:11.9861236Z 59: -- run_test.py: verify result file '/__w/rosbag2/rosbag2/ros_ws/build/rosbag2_transport/test_results/rosbag2_transport/test_burst__rmw_fastrtps_dynamic_cpp.gtest.xml'
2022-07-28T02:21:11.9861412Z 59/78 Test #59: test_burst__rmw_fastrtps_dynamic_cpp ...................................***Failed   11.79 sec
2022-07-28T02:21:11.9861477Z test 60
2022-07-28T02:21:11.9861598Z       Start 60: test_qos__rmw_fastrtps_dynamic_cpp

@MichaelOrlov
Copy link
Contributor

It seems CI failures unrelated to the changes from this PR.
Trying to re-run failing CI jobs.

  • Windows Build Status

@kylemarcey
Copy link
Contributor Author

@MichaelOrlov I tried to reproduce the test_burst__rmw_fastrtps_dynamic_cpp failure locally, but was not able to. Maybe it is a flaky test?

@MichaelOrlov
Copy link
Contributor

CI passed after second iteration.
Merging then

@MichaelOrlov MichaelOrlov merged commit a3b461c into ros2:rolling Jul 29, 2022
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-8-18-2022/27050/1

@MichaelOrlov MichaelOrlov mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp was automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic was automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylemarcey @MichaelOrlov @ros-discourse