Don't allow user to specify unimplemented compression mode 'message' #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piraka9011
approved these changes
May 19, 2020
zmichaels11
approved these changes
May 19, 2020
Karsten1987
approved these changes
May 19, 2020
|
@ros2/aws-oncall - please run this CI job |
|
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/no-message-compression
branch
from
f113666 to
fb19631
Compare
|
Rerun after rebase
|
pjreed
pushed a commit
to pjreed/rosbag2
that referenced
this pull request
May 28, 2020
…os2#415) Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: P. J. Reed <[email protected]>
pjreed
added a commit
to pjreed/rosbag2
that referenced
this pull request
Jun 2, 2020
…essage' (ros2#415)" This reverts commit 75c8126. Signed-off-by: P. J. Reed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user can specify
--compression-mode messageand an "unimplemented" runtime exception is raised upon actually trying to compress the first message. Remove the option to try and use the unimplemented feature.Fixes #413
Follow up issue #414
Signed-off-by: Emerson Knapp [email protected]