move wait_for_shutdown() call out of the context manager #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
|
@Karsten1987 @emersonknapp Please continue looking into this issue. While this patch fixes the incorrect logic of the test it still fails on Windows due to being unable to delete the temporary directory. Since this is a the last failing test please try to resolve it within a week. Otherwise I am tempted to mark the test as |
|
Thanks for this! We are looking at it this week and will mark it xfail if we do not have a resolution by the end of the week. |
emersonknapp
approved these changes
Jul 20, 2020
mjcarroll
approved these changes
Jul 22, 2020
|
@emersonknapp is this good to go or do you guys have another round of review for this? |
|
It's good to go. We're working on fixing the test more thoroughly but this change is good. |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Dirk Thomas <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Dirk Thomas <[email protected]>
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
* Fix for CI regression in TestRos2BagRecord - Replace get_actual_qos() to the qos_profile() as it was before #1335 For some reason on Foxy it doesn't work as expected. Probably due to the missing some underlying dependencies in other core packages. Signed-off-by: Michael Orlov <[email protected]> * Revert "Fix for CI regression in TestRos2BagRecord" This reverts commit f50f46a. Signed-off-by: Michael Orlov <[email protected]> * Skip test_record_qos_profiles on Windows since they are flaky - test_record_qos_profiles failures is a known issue described in the #454 - To fix those tests need to backport #462, #466, #470, #472, #525 - Skipping them for a while Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes (no, it doesn't) #454 this time.
The subprocess started by
launch_testing.tools.launch_process()is only signaled to terminate when the context exits. Therefore callingwait_for_shutdown()within thewithblock doesn't do anything but wait for the timeout. Afterwards it was a race if the process terminated quickly enough so that the file handles from the subprocess where released before the tear down function of the test tries to delete the temporary directory.Moving the
wait_for_shutdown()call outside thewithblock ensures to give the shutdown event enough time to be processed.Windows build testing
ros2bagwith--retest-until-fail 10:Full CI just because: