[foxy] Copy recorder QoS profile to local variable so that temporary value isn't cleared (backport #803)

[mergify]

This is an automatic backport of pull request #803 done by Mergify.
Cherry-pick of 8234765 has failed:

On branch mergify/bp/foxy/pr-803
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 8234765.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_transport/src/rosbag2_transport/recorder.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[MichaelOrlov]

Gist: https://gist.githubusercontent.com/MichaelOrlov/a284e120dd2fd4cf6909edf01a2c6215/raw/ab2f97c7b0a1e89f9451d6b37a98edff131c3c92/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: foxy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12073

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

Re-run CI with focal distro

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

Windows build failed due to the issue in build infrastructure

  Checking Build System

  Building Custom Rule C:/ci/ws/src/ros2/rosidl_typesupport_connext/rosidl_typesupport_connext_cpp/CMakeLists.txt

  identifier.cpp

  wstring_conversion.cpp

     Creating library C:/ci/ws/build/rosidl_typesupport_connext_cpp/Release/rosidl_typesupport_connext_cpp.lib and object C:/ci/ws/build/rosidl_typesupport_connext_cpp/Release/rosidl_typesupport_connext_cpp.exp

CVTRES : fatal error CVT1107: 'C:\Program Files\rti_connext_dds-5.3.1\lib\x64Win64VS2017\nddscpp.lib' is corrupt [C:\ci\ws\build\rosidl_typesupport_connext_cpp\rosidl_typesupport_connext_cpp.vcxproj]

LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt [C:\ci\ws\build\rosidl_typesupport_connext_cpp\rosidl_typesupport_connext_cpp.vcxproj]

---
--- stderr: rosidl_typesupport_connext_cpp
CMake Warning (dev) at C:/ci/ws/install/share/connext_cmake_module/cmake/Modules/FindConnext.cmake:163 (list):
  Policy CMP0121 is not set: The list() command now validates parsing of
  index arguments.  Run "cmake --help-policy CMP0121" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.
  Invalid list index "nddsc.lib".
Call Stack (most recent call first):
  C:/ci/ws/install/share/connext_cmake_module/cmake/Modules/FindConnext.cmake:198 (_count_found_libraries)
  CMakeLists.txt:25 (find_package)