Refactor plugin query mechanism and standardize trait management #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camm73
requested review from
MichaelOrlov and
piraka9011
and removed request for
a team
camm73
force-pushed
the
cameron/refactor-plugin-query
branch
from
ca3f289 to
b507ade
Compare
emersonknapp
requested review from
emersonknapp and
lihui815
and removed request for
piraka9011
emersonknapp
requested changes
Aug 5, 2021
camm73
force-pushed
the
cameron/refactor-plugin-query
branch
2 times, most recently
from
d515acd to
49fd9dc
Compare
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
…gins Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
…ethod (ros2#814) Signed-off-by: Michael Orlov <[email protected]> Signed-off-by: Cameron Miller <[email protected]>
…queue() (ros2#832) Signed-off-by: Michael Orlov <[email protected]> Signed-off-by: Cameron Miller <[email protected]>
* For the `ros2 bag record` CLI - don't hardcode available choices, instead query for what is installed Signed-off-by: Cameron Miller <[email protected]>
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <[email protected]> Signed-off-by: Cameron Miller <[email protected]>
- has_next() - calls recursively until next message OR no next file found - read_next() - calls has_next() to ensure necessary rollovers are made Signed-off-by: Sonia Jin <[email protected]> Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
camm73
force-pushed
the
cameron/refactor-plugin-query
branch
from
49fd9dc to
ccce390
Compare
Signed-off-by: Cameron Miller <[email protected]>
|
Should be good to go now |
emersonknapp
requested review from
emersonknapp
and removed request for
MichaelOrlov
emersonknapp
requested changes
Aug 9, 2021
rosbag2_cpp/include/rosbag2_cpp/converter_interfaces/serialization_format_deserializer.hpp
Outdated
Show resolved
Hide resolved
rosbag2_storage/include/rosbag2_storage/storage_interfaces/read_only_interface.hpp
Outdated
Show resolved
Hide resolved
added 6 commits
August 9, 2021 23:21
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
emersonknapp
approved these changes
Aug 10, 2021
|
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
…2#833) * Refactor plugin query mechanism and standardize trait management * Adds utility function to query all installed plugins for a given plugin interface class, and uses that in rosbag2_py to present options for recording and listing Signed-off-by: Cameron Miller <[email protected]> Signed-off-by: Wojciech Jaworski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored duplicated code for querying available plugins by adding a shared template function in a new
rosbag2_pyutils filepy_utils.hpp.Removed all plugin query code from individual Factory classes to consolidate it within
rosbag2_py.Standardized trait management between
StorageTraits,ConverterTraits, andCompressionTraits.