Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "ignore leaf topics" option to recorder #925

Merged
merged 6 commits into from
Nov 30, 2021
Merged

Add "ignore leaf topics" option to recorder #925

merged 6 commits into from
Nov 30, 2021

Conversation

ivanpauno
Copy link
Member

Fixes #912.

@ivanpauno ivanpauno added the enhancement New feature or request label Nov 29, 2021
@ivanpauno ivanpauno requested a review from a team as a code owner November 29, 2021 20:59
@ivanpauno ivanpauno self-assigned this Nov 29, 2021
@ivanpauno ivanpauno requested review from emersonknapp and hidmic and removed request for a team November 29, 2021 20:59
emersonknapp
emersonknapp approved these changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM with green CI - although I wish it could be slightly less verbose to make one of those tests, that's not your problem to solve with this change.

rosbag2_transport/src/rosbag2_transport/topic_filter.hpp Outdated
@@ -56,6 +58,12 @@ filter_topics_with_known_type(
const std::unordered_map<std::string, std::string> & topics_and_types,
std::unordered_set<std::string> & topic_unknown_types);

ROSBAG2_TRANSPORT_PUBLIC
std::unordered_map<std::string, std::string>
filter_leaf_topics(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a docstring for this please? I know the other functions don't have them (but that's a bad and confusing thing)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, fixed in da80c56.

@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno force-pushed the ivanpauno/recorder-ignore-leaf-topics-options branch from c9d9333 to be6bbe1 Compare November 30, 2021 20:40
@ivanpauno
Copy link
Member Author

I have fixed the deprecation warning that CI catched in c9d9333.

For some reason, the warning is only being emited in windows (some weird interaction between pragmas and templates, I've seen that before ...).

I have also rebased to resolve all the conflicts that were generated when #924 was merged.

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@gbiggs gbiggs merged commit a060c1d into master Nov 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/recorder-ignore-leaf-topics-options branch November 30, 2021 23:26
@emersonknapp
Copy link
Collaborator

Thanks for figuring out the merge - sorry about any difficulty that caused.

@clalancette clalancette mentioned this pull request Apr 29, 2022
Closed
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to recorder to ignore "leaf" topics
3 participants
@ivanpauno @emersonknapp @gbiggs