[backport foxy] Add QoS decoding translation for infinite durations to RMW_DURATION_INFINITE (backport #684) #1088
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
emersonknapp
changed the title
…NFINITE (#684) * Add QoS decoding translation for infinite durations to RMW_DURATION_INFINITE Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit de70a81) Signed-off-by: Emerson Knapp <[email protected]>
…ibrary Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
mergify/bp/foxy/pr-684
branch
from
75ee349 to
9987727
Compare
|
Gist: https://gist.githubusercontent.com/emersonknapp/6b02a51c6326c1689d6f1745f25d064b/raw/0688bfd464a365c6b3a72397c58fc2512c2d6340/ros2.repos
Rerun on focal
|
There was a problem hiding this comment.
@emersonknapp Backport looks good to me.
Only concern about CI failures on Windows
C:\ci\ws\src\ros2\rosbag2\rosbag2_tests\test\rosbag2_tests\test_rosbag2_record_end_to_end.cpp(488): error: Expected: (metadata.relative_file_paths.size()) >= (1), actual: 0 vs 1
Bagfile never split!
[ FAILED ] RecordFixture.record_end_to_end_test_with_zstd_file_compression_compresses_files (1376 ms)
|
Rerun CI for Windows
|
|
It seems that CI Windows job failed to some glitches in infrastructure or race conditions in unit tets.
|
|
@emersonknapp It seems that |
Signed-off-by: Emerson Knapp <[email protected]>
|
Windows: |
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/5b6d727b8a061123e96c0c58c3839d22/raw/0688bfd464a365c6b3a72397c58fc2512c2d6340/ros2.repos
|
|
Rebuil on focal and without connext_dds
|
|
Failure in the Windows CI job in |
|
Re-run the Windows job one more time after rebase.
|
|
The Linux job failed from the previous CI run due to the infrastructure issue related to the java. Thanks @emersonknapp for teaching me how to find an automatically restarted CI job. |
|
Maybe let's wait for #1353 and then run one more clean CI on this one - though it looks like everything is OK here. |
|
@emersonknapp Ahh it will not be green anyway. There are a lot more warnings and random failures. |
This is an automatic backport of pull request #684 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com