Replace language for "db3"/"db"/"database" #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
changed the base branch from
emersonknapp/rosbag2-tests-nosql
to
rolling
emersonknapp
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
emersonknapp
force-pushed
the
emersonknapp/no-database
branch
from
5ba0868 to
78f302a
Compare
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/no-database
branch
from
78f302a to
aeafbc8
Compare
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/no-database
branch
from
84288f5 to
76f6c99
Compare
|
Gist: https://gist.githubusercontent.com/emersonknapp/52279335ac969dd9e3a373476f77defe/raw/f387fb84f3ba221d4d1406d116f4967cfaeba620/ros2.repos
|
james-rms
approved these changes
Dec 5, 2022
MichaelOrlov
approved these changes
Dec 5, 2022
ricardo-manriquez
pushed a commit
to ricardo-manriquez/rosbag2
that referenced
this pull request
Dec 7, 2022
* Remove db3/db/database language Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Ricardo Manríquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup/depends on #1192
Removing explicit mentions to
.db3files in code, as well as changing language to be generic to storage implementation.