Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy] Disable test_record_qos_profiles tests on Windows #1349

Merged
merged 3 commits into from
May 25, 2023
Merged

[foxy] Disable test_record_qos_profiles tests on Windows #1349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921a4ef
Fix for CI regression in TestRos2BagRecord
morlov-apexai May 24, 2023
6162d53
Revert "Fix for CI regression in TestRos2BagRecord"
morlov-apexai May 25, 2023
91bccfd
Skip test_record_qos_profiles on Windows since they are flaky
morlov-apexai May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ros2bag/test/test_record_qos_profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import contextlib
from pathlib import Path
import re
import sys
import tempfile

import unittest
Expand All @@ -31,6 +32,12 @@
import pytest


_is_windows = sys.platform.lower().startswith('win')

if _is_windows:
raise unittest.SkipTest('Skipping test_record_qos_profiles on Windows since they are '
'known to be flaky')

PROFILE_PATH = Path(__file__).parent / 'resources'
TEST_NODE = 'ros2bag_record_qos_profile_test_node'
TEST_NAMESPACE = 'ros2bag_record_qos_profile'
Expand Down Expand Up @@ -62,6 +69,7 @@ def launch_bag_command(self, arguments, **kwargs):
yield pkg_command
cls.launch_bag_command = launch_bag_command

@unittest.skipIf(_is_windows, 'Skipped due to the https://github.com/ros2/rosbag2/issues/454')
def test_qos_simple(self):
profile_path = PROFILE_PATH / 'qos_profile.yaml'
with tempfile.TemporaryDirectory() as tmpdirname:
Expand All @@ -74,6 +82,7 @@ def test_qos_simple(self):
matches = expected_string_regex.search(bag_command.output)
assert not matches, print('ros2bag CLI did not produce the expected output')

@unittest.skipIf(_is_windows, 'Skipped due to the https://github.com/ros2/rosbag2/issues/454')
def test_incomplete_qos_profile(self):
profile_path = PROFILE_PATH / 'incomplete_qos_profile.yaml'
with tempfile.TemporaryDirectory() as tmpdirname:
Expand All @@ -86,6 +95,7 @@ def test_incomplete_qos_profile(self):
matches = expected_string_regex.search(bag_command.output)
assert not matches, print('ros2bag CLI did not produce the expected output')

@unittest.skipIf(_is_windows, 'Skipped due to the https://github.com/ros2/rosbag2/issues/454')
def test_incomplete_qos_duration(self):
profile_path = PROFILE_PATH / 'incomplete_qos_duration.yaml'
with tempfile.TemporaryDirectory() as tmpdirname:
Expand All @@ -99,6 +109,7 @@ def test_incomplete_qos_duration(self):
matches = expected_string_regex.search(bag_command.output)
assert matches, print('ros2bag CLI did not produce the expected output')

@unittest.skipIf(_is_windows, 'Skipped due to the https://github.com/ros2/rosbag2/issues/454')
def test_nonexistent_qos_profile(self):
profile_path = PROFILE_PATH / 'foobar.yaml'
with tempfile.TemporaryDirectory() as tmpdirname:
Expand Down