[humble] Rollback to rcpputils::fs and workaround failure in "open_succeds_twice" on second run.

[MichaelOrlov]

• Fix for regression on on Humble with RHEL created by [humble] Bugfix for writer not being able to open again after closing (backport #1599) #1653
• Replaces Link rcpputils::filesystem to solve error on RHEL #1665

Note. The original failure in the "open_succeeds_twice" on the second run was because rcpputils::fs::delete_all(tmp_dir_) failed to delete the temp folder in destructor because it was there two subfolders.

[clalancette]

Looks good to me with green CI. Thanks for implementing this.

[MichaelOrlov]

Pulls: #1666
Gist: https://gist.githubusercontent.com/MichaelOrlov/b7f6cf28bea1a8d7214f31b873d2c127/raw/de972acc7adda30869dbf8d5429e532c8224d1ee/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_compression rosbag2_tests
TEST args: --packages-above rosbag2_cpp rosbag2_compression rosbag2_tests
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13935

• Linux
• Linux-aarch64
• Windows

[fujitatomoya]

lgtm

[audrow]

Here's a CI run of RHEL, too. (Where the regression was noticed.)

• RHEL

I ran with the same options as above except the EL, which I set to 8. I think this is the right thing to do for RHEL.

[MichaelOrlov]

@ros-pull-request-builder retest this please

[MichaelOrlov]

The CI failure on RHEL is unrelated to the changes from this PR

Failed
rosbag2_py.flake8.E402 (./test/test_convert.py:30:1)

Failing for the past 1 build (Since [#692](https://ci.ros2.org/job/ci_linux-rhel/692/) )
[Took 0 ms.](https://ci.ros2.org/job/ci_linux-rhel/692/testReport/junit/rosbag2_py/flake8/E402____test_test_convert_py_30_1_/history)
Error Message
module level import not at top of file:
from rosbag2_py import (

I would go ahead and merge it.
cc @clalancette @audrow

[MichaelOrlov]

Maybe we have a different version of the flake8 on the RHEL-8?
I've just tried to run flake8 on my local setup on this branch and there are no errors or warnings reported.

[clalancette]

Maybe we have a different version of the flake8 on the RHEL-8?

It is the only platform where we install (parts of) flake8 from pip: https://github.com/ros2/ci/blob/master/linux_docker_resources/Dockerfile-RHEL#L198-L202 . So that may indeed by the case.

[MichaelOrlov]

Ahh, merging then.